feat: add support for parsing async_sequence<T> type
#775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
saschanaz
reviewed
Mar 26, 2024
|
This is now ready for review. |
saschanaz
requested changes
Jan 24, 2025
|
@lucacasonato, ping on updating in response to @saschanaz's comments so we can start propagating this through the spec ecosystem. |
I should probably do this myself... |
lukewarlow
suggested changes
Jul 7, 2025
lib/productions/attribute.js
Outdated
| @@ -75,7 +75,9 @@ export class Attribute extends Base { | |||
| yield* this.extAttrs.validate(defs); | |||
| yield* this.idlType.validate(defs); | |||
|
|
|||
| if (["sequence", "record"].includes(this.idlType.generic)) { | |||
| if ( | |||
| ["async iterable", "sequence", "record"].includes(this.idlType.generic) | |||
There was a problem hiding this comment.
Per whatwg/webidl#1489 this PR should be updated.
There was a problem hiding this comment.
And per #1500 it should be updated a little more, to use the token async_sequence instead.
5 tasks
Merged
5 tasks
2 tasks
saschanaz
changed the title
async iterable<T> typeasync_sequence<T> type
The grammar isn't wrong but it's not valid. It's covered in invalid/idl instead.
saschanaz
approved these changes
Jul 23, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
async iterable<T>(whatwg/webidl#1397).